[Bug 2123954] Review Request: python-PyMunin3 - Python module for developing Munin Multigraph Plugins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2123954



--- Comment #10 from Sandro <gui1ty@xxxxxxxxxxxxx> ---
(In reply to Parag AN(पराग) from comment #8)
> fedora-review output says
> 
> Diff spec file in url and in SRPM
> ---------------------------------
> --- /home/test/2123954-python-PyMunin3/srpm/python-PyMunin3.spec	2022-09-08
> 15:58:56.025887208 +0530
> +++ /home/test/2123954-python-PyMunin3/srpm-unpacked/python-PyMunin3.spec
> 2022-09-05 21:03:54.000000000 +0530
> @@ -1,2 +1,11 @@
> +## START: Set by rpmautospec
> +## (rpmautospec version 0.3.0)
> +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
> +    release_number = 2;
> +    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
> +    print(release_number + base_release_number - 1);
> +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
> +## END: Set by rpmautospec
> +

This is what rpmautospec puts in the file once it is processed by Copr/Koji.

>  %bcond_with tests
> @@ -11,5 +20,5 @@
>  Version:        3.0.1
>  Release:        %{autorelease}
> -Summary:        Python module for developing Munin Multigraph Plugins
> +Summary:        Python module for developing Munin Multigraph Plugins.

I removed the trailing dot after I had it rebuild. I can put it back in. But I
think it should be dropped just like in the description.

>  License:        GPL-3.0-only
> @@ -59,3 +68,12 @@
>  
>  %changelog
> -%autochangelog
> +* Mon Sep 05 2022 Sandro <devel@xxxxxxxxxxxxx> 3.0.1-2
> +- Uncommitted changes
> +
> +* Mon Sep 05 2022 Sandro <devel@xxxxxxxxxxxxx> 3.0.1-1
> +- Fix rpmlint warning and add import test
> +- Fix summary-ended-with-dot
> +- Add %%pyproject_check_import
> +
> +* Sat Sep 03 2022 Sandro <devel@xxxxxxxxxxxxx> Packaging variables read or
> set by %forgemeta-1
> +- Initial package

Again, this is the processing of the %autochangelog tag. Looks a bit messy, I
agree. But the first official release (-1) will only have the "Inital package"
entry. Or I could change that to "Initial release" as is commonly done. The
entries are taken from the git commit messages.

> Please provide updated SRPM as well. SPEC file and same SPEC file in SRPM.

If that is really required, I will trigger another build this evening.

(In reply to Parag AN(पराग) from comment #9)
> Do you have anymore packages submitted for review? or done any other
> unofficial full package review?

No, I don't have any other packages submitted currently. For other activities
see my opening comment (#c0).


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2123954
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux