https://bugzilla.redhat.com/show_bug.cgi?id=2116843 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jkadlcik@xxxxxxxxxx --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Major, thank you for the package. I couldn't properly test it but I tried to import a bunch of classes and it looks alright. > # No tests provided by upstream. ð¢ I think I disagree? When I downloaded the tarball from PyPI, tests are inside. > %if %{with tests} > %pytest > %endif So I think this can be done unconditionally. > %global _description %{expand: > Microsoft Azure Event Hubs Client Library for Python} Please don't copy-paste the Summary here. Fortunatelly, there is a lot of text in the package README, that can be used as a proper description. > %doc README.md CHANGELOG.md I think we should also install the LICENSE file here (using %license macro) > [ ]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/lib/python3.11/site- > packages/azure(python3-azure-mgmt-iothub, python3-azure-mgmt- > recoveryservicesbackup, python3-azure-mgmt-security, python3-azure- The fedora-review tool complains about this. It seems to me that this package tries to claim ownership of /usr/lib/python3.11/site-packages/azure/ but instead, it should try to own only /usr/lib/python3.11/site-packages/azure/eventhub/ --- Also, please note that the package works only for F37+, on older versions it fails to build because of No matching package to install: 'python3dist(typing-extensions) >= 4.0.1' Which is okay, I am just pointing it out. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2116843 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
