https://bugzilla.redhat.com/show_bug.cgi?id=2124697 Richard W.M. Jones <rjones@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefanha@xxxxxxxxxx Flags| |needinfo?(stefanha@redhat.c | |om) --- Comment #1 from Richard W.M. Jones <rjones@xxxxxxxxxx> --- This is not quite ready for review yet! I have some questions of the package author to be resolved first. Stefan: - Shouldn't this depend on liburing-devel? I added that as a BR, but I'm not sure if that is correct. - Cargo doesn't build the *.so.* files, so I had to manually link them which does not seem ideal: pushd %{buildroot}%{_libdir} ln -s libblkio.so libblkio.so.0 ln -s libblkio.so.0 libblkio.so.0.0 popd - I suspect this will not actually build in Koji because it's going to try to pull in a whole load of cargo dependencies which are not listed as BRs. Will try a scratch build soon and post the results. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2124697 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
