https://bugzilla.redhat.com/show_bug.cgi?id=2120129 --- Comment #6 from Alessandro Astone <ales.astone@xxxxxxxxx> --- (In reply to Maíra Canal from comment #5) > (In reply to Alessandro Astone from comment #4) > > (In reply to Maíra Canal from comment #3) > > > Hi Alessandro, > > > > > > Just a few nitpicks on your spec. > > > > > > > %global pypi_name pyclip > > > > > > Setting and using this macro makes the spec file harder to read. Using the > > > literal name makes it easier to read. Moreover, sometimes you don't even use > > > this macro and write "pyclip" literally, for example, on the URL. > > I don't know about that. I just followed what all other pypi specs do. > > %{pypi_name} in github URL doesn't make sense. > > Maybe there can be a little confusion in this sense as the Python Packaging > Guidelines > changed in 2021 [1]. You can check the new example spec file on the docs. > Your spec file > looks like is following much of the “201x-era” Python packaging guidelines. > > [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > > Best Regards, > - Maíra Canal > Done. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2120129 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
