https://bugzilla.redhat.com/show_bug.cgi?id=2103073 --- Comment #7 from Maxwell G <gotmax@e.email> --- (In reply to Pavel Raiskup from comment #6) > Thank you for the update, and sorry for delay (I was on vacation). > > (In reply to Maxwell G from comment #5) > > This no longer sorts properly. You should remove the previous entries. > > I fixed the changelog. I started from scratch, it shouldn't be a problem > since > the package is not in Fedora, yet. Yeah, that's good. Generally, packages should only have one changelog entry on import. > > > ``` > > install -p -m 0644 doc/fugitive-gitlab.txt %{buildroot}%{vimfiles_root}/doc > > install -p -m 0644 plugin/gitlab.vim %{buildroot}%{vimfiles_root}/plugin > > for filename in api fugitive omnifunc utils; do > > install -p -m 0644 autoload/gitlab/$filename.vim > > %{buildroot}%{vimfiles_root}/autoload/gitlab > > done > > ``` > > > > This seems unnecessarily convoluted. Why don't you just use `cp -rp`to copy > > the directories that you need? > > I prefer this because I have the list of files (and the permissions) fully > under control. I can change this, please just state it is really your > preference. I don't mind. > > > > Requires: vim-common > > > > This should only depend on vim-filesystem. > > I think you need a proper vim runtime to use vim fugitive plugin, so > vim-filesystem wouldn't be enough? OTOH, the package already depends on > vim-fugitive (which transitively depends on vim-common). So I'm just > removing this dependency. >From what I've seen, most vim plugin packages just depend on vim-filesystem. Please directly depend on that. It owns the directories. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2103073 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
