https://bugzilla.redhat.com/show_bug.cgi?id=2123618 --- Comment #4 from Sandro <gui1ty@xxxxxxxxxxxxx> --- (In reply to Parag Nemade from comment #3) > (In reply to Sandro from comment #2) > > Thank you for having a look at this package. > > > Issues: > > ======= > > - If (and only if) the source package includes the text of the license(s) > > in its own file, then that file, containing the text of the license(s) > > for the package is included in %license. > > Note: License file AUTHORS.md is not marked as %license > > See: https://docs.fedoraproject.org/en-US/packaging- > > guidelines/LicensingGuidelines/#_license_text > > > > ^^AUTHORS.md should be included in %doc or dropped. > > Actually this file is getting installed, hence fedora-review tool > considering it as license file and asking to mark it as %license > /usr/lib/python3.11/site-packages/hatch_fancy_pypi_readme-22.3.0.dist-info/ > licenses/AUTHORS.md > > but it should not get installed in that location. Reported upstream > https://github.com/hynek/hatch-fancy-pypi-readme/issues/8 I had some fun this afternoon, trying to get rid of AUTHORS.md in all kind of ways. When finally I succeeded, the tests would no longer pass: =================================== FAILURES =================================== ___________________________ TestCLIEndToEnd.test_ok ____________________________ self = <tests.test_cli.TestCLIEndToEnd object at 0x7f68243a6a90> def test_ok(self): """ A valid config is rendered. """ > out = run("hatch_fancy_pypi_readme", "tests/example_pyproject.toml") tests/test_cli.py:52: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ check = True, args = ('hatch_fancy_pypi_readme', 'tests/example_pyproject.toml') process = CompletedProcess(args=['/usr/bin/python3', '-m', 'hatch_fancy_pypi_readme', 'tests/example_pyproject.toml'], returncod...^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nFileNotFoundError: [Errno 2] No such file or directory: \'AUTHORS.md\'\n') There's something fishy about AUTHORS.md. It should definitely not be installed in the license directory inside the whl archive. Not sure if this is a bug or an incomplete pyproject.toml. Best to get clarification from upstream. > > > > Requires > > -------- > > python3-hatch-fancy-pypi-readme (rpmlib, GLIBC filtered): > > /usr/bin/python3 > > python(abi) > > python3.11dist(hatchling) > > > > ^^^According to the pyproject.toml this appears to be a build requirement > > only. > > > > but i see it is also runtime required package > src/hatch_fancy_pypi_readme/hooks.py:9:from > hatchling.metadata.plugin.interface import MetadataHookInterface You are right. It's a build as well as a runtime dependency. And the requires is determined by rpmbuild itself. So, all good on this issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2123618 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
