https://bugzilla.redhat.com/show_bug.cgi?id=2091310 Ben Beasley <code@xxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #9 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Rather than filling out the review template again, I note the following: - The spec file diff, below, includes all of the changes suggested in the original review and no other changes that could introduce new issues. --- ../../2091310-python-ufo2ft/srpm-unpacked/python-ufo2ft.spec 2022-08-28 19:46:25.000000000 -0400 > +++ srpm-unpacked/python-ufo2ft.spec 2022-08-30 12:50:53.000000000 -0400 > @@ -5,10 +5,12 @@ > %forgemeta > > Name: python-%{srcname} > -Release: 1%{?dist} > +Release: 2%{?dist} > Summary: A bridge from UFOs to FontTool objects > > -License: MIT > +# The entire source is (SPDX) MIT, except: > +# - Lib/ufo2ft/filters/propagateAnchors.py is Apache-2.0 > +License: MIT and Apache-2.0 > URL: %forgeurl > Source0: %{pypi_source %{srcname}} > > @@ -48,9 +50,6 @@ > %prep > %forgeautosetup -N > %patch01 -p1 > -#pushd Lib > -#rm -rf *.egg-info > -#popd > > %generate_buildrequires > %pyproject_buildrequires > @@ -73,10 +72,12 @@ > > > %files -n python3-%{srcname} -f %{pyproject_files} > -%license LICENSE > %doc README.rst > > %changelog > +* Tue Aug 30 2022 Benson Muite <benson_muite@xxxxxxxxxxxxx> - 2.28.0-2 > +- Update license information as indicated in review > + > * Sun Aug 28 2022 Benson Muite <benson_muite@xxxxxxxxxxxxx> - 2.28.0-1 > - Update version > - Add patch to relax dependency requirements - The only rpmlint messages on the new package are spurious; rpmlint does not yet understand SPDX license identifiers and expressions. > =============================================== rpmlint session starts =============================================== > rpmlint: 2.2.0 > configuration: > /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml > /etc/xdg/rpmlint/fedora.toml > /etc/xdg/rpmlint/licenses.toml > /etc/xdg/rpmlint/scoring.toml > /etc/xdg/rpmlint/users-groups.toml > /etc/xdg/rpmlint/warn-on-functions.toml > checks: 32, packages: 2 > > python-ufo2ft.src: W: invalid-license Apache-2.0 > python3-ufo2ft.noarch: W: invalid-license Apache-2.0 > ================ 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.6 s ================ The package is therefore APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2091310 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
