[Bug 2106611] Review Request: passt - User-mode networking daemons for virtual machines and namespaces

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2106611



--- Comment #15 from Stefano Brivio <sbrivio@xxxxxxxxxx> ---
(In reply to Daniel Berrangé from comment #13)
> ===== ISSUES =====
> 
> [!]: Package requires other packages for directories it uses.
>      Note: No known owner of /usr/share/selinux/packages/passt,
>      /usr/share/doc/passt
> 
>     => Needs %dir entries for these two

Added.

> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners:
>      /usr/share/selinux/packages/passt, /usr/share/doc/passt,
>      /usr/share/selinux, /usr/share/selinux/packages
> 
>     => Needs a Requires: selinux-policy

Added.

> [!]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in passt-
>      selinux
> 
>     => Needs %{?_isa} bit adding

Left as it was: the SELinux policy subpackage is actually a "noarch" package,
and the guidelines say:

  "When a subpackage requires the base package, it must do so using a fully
versioned arch-specific (for non-noarch packages) dependency"

...which makes sense I suppose: even if %{?_isa} is "noarch", or empty, so that
should work in any case. I guess fedora-review doesn't catch this corner case.

---

Fabio,

(In reply to Fabio Valentini from comment #14)
> 
> Just FYI, the rpkg macros are not available in Fedora's build system (only
> in COPR) and they are no longer maintained.

Thanks for mentioning this, I didn't realise they are no longer maintained.

> If you want to automate Release / %changelog, then rpmautospec (%autorelease
> / %autochangelog) is currently the only officially supported way to do that.

I'm not actually using the {{{ git_dir_changelog }}} rpkg-utils macro, I wrote
a different one for this purpose, because git_dir_changelog would report a line
for every single upstream commit (with possibility of editing), which clearly
conflicts with packaging guidelines. If one day Copr stops allowing macro usage
altogether, I would rather call my macro (a rather simple shell function) from
the upstream Makefile, I guess.

As to the unavailability on Fedora's build system, yes, I already planned for
that -- I would simply copy the spec file as processed by rpkg, and keep it
updated in Fedora's git.

---

Updated spec file and SRPM:

Spec URL:
https://download.copr.fedorainfracloud.org/results/sbrivio/passt/fedora-rawhide-x86_64/04805487-passt/passt.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/sbrivio/passt/fedora-rawhide-x86_64/04805487-passt/passt-0^20220902.g7ce9fd1-1.fc38.src.rpm


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2106611
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux