[Bug 2076836] Review Request: bitwise - Terminal based bit manipulator in ncurses

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2076836



--- Comment #3 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> ---
> This header file is also part of the "shunting-yard code" and it's
> by the same author.  

Understood

> You're right. I fixed it and also updated the license identifiers to use SPDX.

+1 for SPDX

Though, I am really sorry but I think you had the correct GPL license
before I weighed in. I am reading the packaged COPYING file again and
now I can see the 'GNU General Public License "or any later version"'
line there. I don't know why I missed it before, sorry. So I think it
is GPL-3.0-or-later after all.

Also, please take a look at the licensecheck.txt here:


    *No copyright*  [generated file]
    --------------------------------
    bitwise-v0.43/bitwise.1

    BSD 2-Clause License
    --------------------
    bitwise-v0.43/inc/shunting-yard.h
    bitwise-v0.43/inc/stack.h
    bitwise-v0.43/src/shunting-yard.c
    bitwise-v0.43/src/stack.c
    bitwise-v0.43/tests/test-shunting-yard.c

    FSF All Permissive License
    --------------------------
    bitwise-v0.43/m4/ax_lib_readline.m4

    FSF Unlimited License (with License Retention) [generated file]
    ---------------------------------------------------------------
    bitwise-v0.43/aclocal.m4

    FSF Unlimited License [generated file]
    --------------------------------------
    bitwise-v0.43/configure

    GNU General Public License v2.0 or later [generated file]
    ---------------------------------------------------------
    bitwise-v0.43/compile
    bitwise-v0.43/depcomp
    bitwise-v0.43/missing
    bitwise-v0.43/test-driver

    Unknown or generated
    --------------------
    bitwise-v0.43/COPYING
    bitwise-v0.43/ChangeLog
    bitwise-v0.43/Makefile.am
    bitwise-v0.43/README
    bitwise-v0.43/configure.ac
    bitwise-v0.43/inc/bitwise.h
    bitwise-v0.43/inc/config.h.in
    bitwise-v0.43/src/cmd.c
    bitwise-v0.43/src/help.c
    bitwise-v0.43/src/interactive.c
    bitwise-v0.43/src/main.c
    bitwise-v0.43/src/misc.c

    X11 License [generated file]
    ----------------------------
    bitwise-v0.43/install-sh

    [generated file]
    ----------------
    bitwise-v0.43/Makefile.in


> Both files have the same content. I think it's fine to just install
> one of them. 

Ack, no problem. I would copy both to be extra sure but since they are
same, installing just one is reasonable.


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2076836
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux