https://bugzilla.redhat.com/show_bug.cgi?id=2118487 Timothée Floure <timothee.floure@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo? --- Comment #3 from Timothée Floure <timothee.floure@xxxxxxxxxx> --- I would add the following points to Sandro's review: * The following line is present commented in the install section: please either remove it or give context. #echo "export let NAVIGATOR_VERSION = \"%{version}\";" > %{buildroot}%{_datadir}/cockpit/navigator/version.js * The Requires section looks fishy to me: - python is nowhere to be found when I grep the codebase. - rsync and zip are only used in the Makefile (which you don't use!). - Upstream has a list of dependencies for EPEL8: see https://github.com/45Drives/cockpit-identities/blob/main/manifest.json#L43 and https://github.com/45Drives/cockpit-identities/blob/main/packaging/el8/main.spec - Various command-line utilities such as smbpasswd and chsh are called from the codebase, hence must be provided via the package's dependencies. See upstream's dependency list and `grep -R -i spawn identities/`. * I don't see the point of mentioning 'Cockpit Identities` in the description section, but that's only cosmetic. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2118487 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
