https://bugzilla.redhat.com/show_bug.cgi?id=2122170 --- Comment #2 from Ben Beasley <code@xxxxxxxxxxxxxxxxxx> --- Thank you for the review. > a) Header files are ok in documentation as these are examples I agree. > b) Why not package a tagged release version rather than a commit? The last release was only a few months before the last commit. I commented in lines 1-2 of the spec file: # We use a git snapshot because the release tag does not contain the # CHANGELOG.md and README.md updates for the release. The commits from the release tag to the selected commit only include irrelevant updates to FUNDING.yml and the CHANGELOG.md and README.md entries for the release I am packaging. Basically, upstream just tagged the release too soon. > c) BSD 3 clause is for a file that is not packaged. I agree, thus the License of simply “MIT”. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2122170 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
