https://bugzilla.redhat.com/show_bug.cgi?id=2087174 Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtasaka@xxxxxxxxxxxxxxxxx --- Comment #2 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- So as I happen to be telepathy-glib maintainer, I comment for now. * Now for new packages License field must use SPDX identifier: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names https://spdx.org/licenses/ * For BuildRequires: using "BuildRequires: pkgconfig(foo)" is preferred than to use "BuildRequires: dbus-glib-devel" or so https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/ * Unneeded BR - At least "BR: openssl-devel" seems unneeded - Also check if there is any more unneeded BRs left. * Using "python-unversioned-command" as BR is strongly discouraged. Patch out not to use non-version python and use python3. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_dependencies * scratch build says: checking for Python with Twisted and IRC protocol support... no https://koji.fedoraproject.org/koji/taskinfo?taskID=91402714 Looking at configure.ac, this perhaps means that some twisted tests are disabled. Please consider to enable this. * Directory ownership: https://docs.fedoraproject.org/en-US/packaging-guidelines/UnownedDirectories/ With "mock --init" and doint "mock --install telepathy-idle.x86_64.rpm", /usr/share/dbus-1/services/ is not owned by any packages. ============================================================= [mockbuild@93f3667e0cdb434cb87064920e66e928 ~]$ rpm -qf /usr/share/dbus-1/services/ file /usr/share/dbus-1/services is not owned by any package ============================================================= Make it sure this directory is owned by some package when telepathy-idle is installed. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2087174 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
