https://bugzilla.redhat.com/show_bug.cgi?id=2121250 --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- (In reply to Jerry James from comment #4) > I've never used rust2rpm, so I know next to nothing about it. Fair enough. It helps to compare the submitted spec file (which might contain manual modifications) with one that is generated by rust2rpm (i.e. without manual modifications). And any manual changes would need to make sense. > Are you suggesting that the entire spec file should be automatically generated, with no tweaks by a packager? Yes and no. The "core" of the package should be correctly and successfully generated by running rust2rpm. But there are cases where the packager needs to make manual adjustments on top of that, for example, disabling tests that don't work, or packaging additional files that aren't tracked by Cargo.toml package metadata (man pages, shell completions, etc.). Additionally, for Rust binaries, the license tag for the subpackage that contains the binary needs to be manually populated according to all statically linked dependencies. > So the man page in the wrong package and the wrong path in this case represents a bug in rust2rpm? No. Manual pages are not automatically added by rust2rpm, so in this case, the packager has added it to the wrong subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121250 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
