https://bugzilla.redhat.com/show_bug.cgi?id=2121982 --- Comment #3 from Davide Cavalca <dcavalca@xxxxxx> --- Thanks for the review! > a) Licensing seems ok, MIT license is generated for the documentation https://python-asn1.readthedocs.io/en/latest/license.html Yep, afaict the whole thing is under MIT, and the generated one is just a pretty rendering of the license, but the actual text is the same as the one in LICENSE (which is what I'm marking as %license for all subpackages) > b) The requirements seem to be more than what you have listed in the spec file: This package is using the dependency generator per the new python packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#Automatically-generated-dependencies so the only BRs explicitly listed in the package are the ones the generation didn't pick up automatically. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2121982 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue