https://bugzilla.redhat.com/show_bug.cgi?id=2054410 --- Comment #3 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- Spec URL: https://mikel.olasagasti.info/tmp/fedora/shdoc.spec SRPM URL: https://mikel.olasagasti.info/tmp/fedora/shdoc-0-1.20220827gitb64998d.fc36.src.rpm - Updated to include latest commits - Change order for shortcommit and snapinfo - Added note about version (In reply to Jakub Kadlčík from comment #1) > Hello Mikel, > thank you for the package. > > > %global commit 6e362b7b52291e0bfb1f28ccbe2968aa592ddc07 > > %global snapinfo 20220214git%{shortcommit} > > %global shortcommit %(c=%{commit}; echo ${c:0:7}) > > I am surprised that rpmbuild doesn't complain about %{shortcommit} > being undefined on the second line. But it works, so I think it's > fine. I must have copied it from somewhere and didn't realize about the order as it was not failing. Fun fact, I suggested to change order in a spec review I did in the past. > > Version: 0 > > Release: %autorelease -s %{snapinfo} > > This is AFAIK correct > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/ > #_upstream_has_never_chosen_a_version > > but can you please submit an upstream issue asking them to release a > proper version, and link it here in the spec? So that we can > eventually move to something stable. https://github.com/reconquest/shdoc/issues/55 (In reply to Benson Muite from comment #2) > Tests seem to be available: > https://github.com/reconquest/shdoc/tree/master/tests > Can these be added in a %check section? I checked again, as I didn't remember why I didn't add checks. The problem is that tests require some "bash vendoring" that author designed that I don't think it's possible to use in Fedora without non-trivial changes. https://github.com/reconquest/shdoc/blob/master/tests/run_tests#L8 -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2054410 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
