https://bugzilla.redhat.com/show_bug.cgi?id=2118487 Sandro <gui1ty@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gui1ty@xxxxxxxxxxxxx --- Comment #1 from Sandro <gui1ty@xxxxxxxxxxxxx> --- I'm looking forward to this one, myself. This is my first package review. I'm trying to get acquainted with the process and I'm looking for a sponsor. Package looks good. I discovered a couple of minor issues. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues ====== /usr/share/cockpit/identities/.gitignore /usr/share/cockpit/identities/.vscode A couple of leftovers from the VCS and/or the build tools. Please remove. /usr/share/cockpit/identities/public/assets/images/45d-fan-light.svg Above file has executable bits set and as such rpmlint complains about "script without shebang". Please use correct permissions. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later", "*No copyright* GNU General Public License, Version 3", "*No copyright* [generated file]". 24 files have unknown license. Detailed output of licensecheck in /home/sandro/devel/fedora/2118487-cockpit- identities/licensecheck.txt [?]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [?]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. ^ I installed it, but was unable to figure out how to enable it for cockpit. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Ran it manually: rpmlint results/cockpit-identities-0.1.10-1.fc38.*rpm srpm/cockpit-identities.spec ======================================================= rpmlint session starts ======================================================= rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 cockpit-identities.noarch: E: version-control-internal-file /usr/share/cockpit/identities/.gitignore cockpit-identities.src: W: strange-permission cockpit-identities.spec 600 cockpit-identities.noarch: E: script-without-shebang /usr/share/cockpit/identities/public/assets/images/45d-fan-light.svg cockpit-identities.spec:44: W: macro-in-comment %{version} cockpit-identities.spec:44: W: macro-in-comment %{buildroot} cockpit-identities.spec:44: W: macro-in-comment %{_datadir} cockpit-identities.spec:35: W: macro-in-comment %{version} cockpit-identities.spec:35: W: macro-in-comment %{buildroot} cockpit-identities.spec:35: W: macro-in-comment %{_datadir} cockpit-identities.noarch: W: hidden-file-or-dir /usr/share/cockpit/identities/.vscode cockpit-identities.noarch: W: hidden-file-or-dir /usr/share/cockpit/identities/.vscode ======================== 2 packages and 1 specfiles checked; 2 errors, 9 warnings, 2 badness; has taken 0.3 s ======================== ^ Already discussed under issues. Rest is due to rpmautospec, I assume. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/45Drives/cockpit-identities/archive/v0.1.10/cockpit-identities-0.1.10.tar.gz : CHECKSUM(SHA256) this package : 046108e00bf33529320a3f803e8d745a87328df802631fab6a9a45aa7e88e513 CHECKSUM(SHA256) upstream package : 046108e00bf33529320a3f803e8d745a87328df802631fab6a9a45aa7e88e513 Requires -------- cockpit-identities (rpmlib, GLIBC filtered): cockpit-system python3 rsync zip Provides -------- cockpit-identities: cockpit-identities Diff spec file in url and in SRPM --------------------------------- --- /home/sandro/devel/fedora/2118487-cockpit-identities/srpm/cockpit-identities.spec 2022-08-27 11:03:47.722122561 +0200 +++ /home/sandro/devel/fedora/2118487-cockpit-identities/srpm-unpacked/cockpit-identities.spec 2022-08-16 00:34:55.000000000 +0200 @@ -1,2 +1,11 @@ +## START: Set by rpmautospec +## (rpmautospec version 0.2.6) +%define autorelease(e:s:pb:) %{?-p:0.}%{lua: + release_number = 1; + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); + print(release_number + base_release_number - 1); +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{?dist} +## END: Set by rpmautospec + %global forgeurl https://github.com/45Drives/cockpit-identities/ Version: 0.1.10 @@ -44,3 +53,4 @@ %changelog -%autochangelog +* Mon Aug 15 2022 Stephen Gallagher <sgallagh@xxxxxxxxxx> 0.1.10-1 +- First pass ^ That's okay. Difference due to rpmautospec being used. Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2118487 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, SugarActivity, R, Ocaml, Python, Haskell, Perl, Java, PHP, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2118487 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
