https://bugzilla.redhat.com/show_bug.cgi?id=2120883 --- Comment #2 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- > - Licensecheck shows a BSD-2-Clause file: > vorta-0.8.7/src/vorta/qt_single_application.py > Please change the License tag to reflect this. Fixed > - The icons in %{python3_sitelib}/vorta/assets/icons are bundled FontAwesome > icons; see the last line of README.md. If you can figure out which version > of FontAwesome they belong to, it would be good to unbundle them and depend > on one of the fontawesome-fonts or fontawesome5-fonts packages instead. > (This will also let you avoid accounting for the license of those icons in > the License tag.) Do you have any suggestions on how to best accomplish that? It looks like vorta upstream has mucked with all the files names so it'd be no easy task to rely on FA or to maintain it. Perhaps long term I can ask upstream if they'll use the stock FA names/directory structure so that we can do just this. I added the appropriate license to the License tag. > - The two hicolor SVG icons are executable, which is why rpmlint issues the > script-without-shebang error; see rpmlint output below. Fixed. > - Speaking of rpmlint output, there is no man page for vorta. This is > optional, > but if you would like to ship a man page, add this: > > BuildRequires: help2man > > Then in %install, do something like this: > > export PYTHONPATH=%{buildroot}%{python3_sitelib} > mkdir -p %{buildroot}%{_mandir}/man1 > help2man -N -o %{buildroot}%{_mandir}/man1/vorta.1 > %{buildroot}%{_bindir}/vorta > > And, of course, add the man page to %files. Since it's a GUI application I didn't bother making a man page since most uses will be via GUI accesses. The built in help should be sufficient here. > - It is almost possible to run the tests. If you add this: > > BuildRequires: mesa-dri-drivers > BuildRequires: xorg-x11-fonts-Type1 > BuildRequires: xorg-x11-server-Xvfb > > And redefine a macro: > > %global __pytest xvfb-run -d /usr/bin/pytest > > Then this *almost* works: > > %check > %pytest > > Except pytest-qt is needed and, alas, we don't have it in Fedora. If we > ever > get it, the above trick should work. That info is incredibly helpful, thank you. Spec URL: https://jonathanspw.fedorapeople.org/vorta.spec SRPM URL: https://jonathanspw.fedorapeople.org/vorta-0.8.7-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120883 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
