https://bugzilla.redhat.com/show_bug.cgi?id=1871171 --- Comment #35 from Maxwell G <gotmax@e.email> --- Okay, I ran this through fedora-review. In addition to the comment about naming above, it uncovered a couple more small issues. Thank you for sticking with this! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ==== Reviewer Notes ==== > %package doc > Summary: Examples for python-rpi-gpio2 > %description doc > A set of examples for python-rpi-gpio2 I would recommend adding a newline or two before %description to make the spec file more readable The package obsoleting does not appear correct to me. Here is how I'd approach it: > Obsoletes: python-rpi-gpio = %{version}-%{release} > Provides: python-rpi-gpio These shouldn't be necessary. There is no binary package named python-rpi-gpio2. > Obsoletes: python3-RPi.GPIO <= 0.7.1 The constraint should be "< 0.7.0-7". See https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages. > Provides: python3-RPi.GPIO = %{version}-%{release} I would make this python3-RPI.GPIO = 1:%{version}-%{release}. Normally, we try to avoid epochs, but this is necessary, as the latest version of rpi-gpio2 sorts before the last version of rpi-gpio. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License v3.0 or later". 40 files have unknown license. Detailed output of licensecheck in /tmp/tmp.aolsHa4fGS/python-rpi- gpio2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [!]: Package is named according to the Package Naming Guidelines. See my previous comment. [?]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-RPi.GPIO2 [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. Noarch package. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-RPi.GPIO2.noarch: W: self-obsoletion python3-RPi.GPIO <= 0.7.1 obsoletes python3-RPi.GPIO = 0.4.0-1.fc38 See the note above. python-rpi-gpio2-doc.noarch: W: invalid-license GPL-3.0-or-later python3-RPi.GPIO2.noarch: W: invalid-license GPL-3.0-or-later This is okay. rpmlint is not yet aware of the new licensing guidelines. 2 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/underground-software/RPi.GPIO2/archive/v0.4.0/RPi.GPIO2-0.4.0.tar.gz : CHECKSUM(SHA256) this package : fe2f7ff0ce98a814b885be973be7976fe84e27fe15f69e7ef799e9ac4d8a5b06 CHECKSUM(SHA256) upstream package : fe2f7ff0ce98a814b885be973be7976fe84e27fe15f69e7ef799e9ac4d8a5b06 Requires -------- python3-RPi.GPIO2 (rpmlib, GLIBC filtered): python(abi) python3-libgpiod python-rpi-gpio2-doc (rpmlib, GLIBC filtered): Provides -------- python3-RPi.GPIO2: python-RPi.GPIO2 python3-RPi.GPIO python3-RPi.GPIO2 python3.11-RPi.GPIO2 python3.11dist(rpi-gpio2) python3dist(rpi-gpio2) python-rpi-gpio2-doc: python-rpi-gpio2-doc Generated by fedora-review 0.9.0 (6761b6c) last change: 2022-08-23 Command line :/usr/bin/fedora-review -prn python-rpi-gpio2 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Ocaml, C/C++, Perl, R, fonts, PHP, Haskell, Java, SugarActivity Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=1871171 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
