https://bugzilla.redhat.com/show_bug.cgi?id=2121595 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(loganjerry@gmail. | |com) | --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thanks for the review! (In reply to Jonathan Wright from comment #1) > > BuildRequires: %{py3_dist pip} > > BuildRequires: %{py3_dist setuptools} > > BuildRequires: %{py3_dist wheel} > > This can all be replaced by the following in %prep: [1] > > %generate_buildrequires > %pyproject_buildrequires As I mentioned in the other review you did for me, I deliberately do not use automatically generated BuildRequires. > > BuildRequires: %{py3_dist pytest} > > This one should be replaced with `pytest` or `python3-pytest` instead of the > %{py3_dist} macro. Also mentioned in the other review: I see no reason to avoid the py3_dist macro. > You need to include the license. > > + %license LICENSE One of the benefits of using the %pyproject* macros is that the license file is included in the dist-info [1]. In this case, a query shows that the binary RPM does include the license, and that it is marked as a license: $ rpm -qL python3-uc-micro-py-1.0.1-1.fc38.noarch.rpm /usr/lib/python3.11/site-packages/uc_micro_py-1.0.1.dist-info/LICENSE [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros -- see the %pyproject_save_files description -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2121595 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
