https://bugzilla.redhat.com/show_bug.cgi?id=2071547 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST --- Comment #5 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: * Package builds and installs * Package naming complies with the guidelines * Package licensing is correct and license file is installed There is one minor issue: I'd advise you fix the file list so that you correctly own your OBS service content: Either: %dir %{_prefix}/lib/obs/service %{_prefix}/lib/obs/service/* Or: %{_prefix}/lib/obs/service/ It's trivial to fix on import, so I'll let you do that then. PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2071547 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
