https://bugzilla.redhat.com/show_bug.cgi?id=2120129 Maíra Canal <mairacanal@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mairacanal@xxxxxxxxxx --- Comment #3 from Maíra Canal <mairacanal@xxxxxxxxxx> --- Hi Alessandro, Just a few nitpicks on your spec. > %global pypi_name pyclip Setting and using this macro makes the spec file harder to read. Using the literal name makes it easier to read. Moreover, sometimes you don't even use this macro and write "pyclip" literally, for example, on the URL. > %package -n python%{python3_pkgversion}-%{pypi_name} Instead of %{python3_pkgversion}, you can use simply 3. > BuildRequires: pyproject-rpm-macros I believe this package is not needed for building. Moreover, pyclip contains tests that are not being called on the spec file. It would be nice to have the tests. NOTE: I'm not a packager yet and currently looking for sponsorship. Best Regards, - Maíra Canal -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2120129 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
