https://bugzilla.redhat.com/show_bug.cgi?id=2119987 Maíra Canal <mairacanal@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mairacanal@xxxxxxxxxx --- Comment #2 from Maíra Canal <mairacanal@xxxxxxxxxx> --- Hi Simone, Just a few nitpicks on your spec. > %{?!python3_pkgversion:%global python3_pkgversion 3} Using the %{python3_pkgversion} macro instead of using 3 on the BuildRequires packages, makes it harder to read. Usually, it is a better practice to drop the %{python3_pkgversion} macro. > %global srcname icapclient3 Another readability nit, setting and using this makes the spec file harder to read. Using the literal name makes it easier to read. Moreover, sometimes you don't even use this macro and write "icapclient3" literally. > %{?python_provide:%python_provide python3-%{srcname}} This is deprecated and shouldn't be used. Check the note at the end of https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_the_py_provides_macro NOTE: I'm not a packager yet and currently looking for sponsorship. Best Regards, - Maíra Canal -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119987 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
