https://bugzilla.redhat.com/show_bug.cgi?id=2119499 Benson Muite <benson_muite@xxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benson_muite@xxxxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |benson_muite@xxxxxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #5 from Benson Muite <benson_muite@xxxxxxxxxxxxx> --- Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file COPYING is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU Lesser General Public License, Version 2.1", "FSF All Permissive License", "[generated file]", "*No copyright* GNU Lesser General Public License, Version 2.1", "FSF Unlimited License (with License Retention) GNU General Public License v2.0 or later [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "X11 License [generated file]", "GNU General Public License v2.0 or later", "GNU Lesser General Public License v2.1 or later", "FSF Unlimited License (with License Retention) GNU General Public License, Version 2", "FSF Unlimited License (with License Retention)", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "GNU Library General Public License, Version 2.0", "GNU Lesser General Public License". 86 files have unknown license. Detailed output of licensecheck in /home/benson/Projects/FedoraPackaging/SDL2_Pango/2119499-SDL2_Pango/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [!]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 204800 bytes in 26 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in SDL2_Pango-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/markuskimius/SDL2_Pango/archive/v2.1.4/SDL2_Pango-2.1.4.tar.gz : CHECKSUM(SHA256) this package : 226a317aa81a7d0f16c3306ed397495172b1a82a0a43a90b6b3f3d4869cfbf76 CHECKSUM(SHA256) upstream package : 226a317aa81a7d0f16c3306ed397495172b1a82a0a43a90b6b3f3d4869cfbf76 Requires -------- SDL2_Pango (rpmlib, GLIBC filtered): libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libharfbuzz.so.0()(64bit) libpango-1.0.so.0()(64bit) libpangoft2-1.0.so.0()(64bit) rtld(GNU_HASH) SDL2_Pango-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config SDL2-devel SDL2_Pango libSDL2_Pango.so.3()(64bit) pango-devel pkgconfig pkgconfig(pango) SDL2_Pango-debuginfo (rpmlib, GLIBC filtered): SDL2_Pango-debugsource (rpmlib, GLIBC filtered): Provides -------- SDL2_Pango: SDL2_Pango SDL2_Pango(x86-64) libSDL2_Pango.so.3()(64bit) SDL2_Pango-devel: SDL2_Pango-devel SDL2_Pango-devel(x86-64) pkgconfig(SDL2_Pango) SDL2_Pango-debuginfo: SDL2_Pango-debuginfo SDL2_Pango-debuginfo(x86-64) debuginfo(build-id) libSDL2_Pango.so.3.1.0-2.1.4-.fc38.x86_64.debug()(64bit) SDL2_Pango-debugsource: SDL2_Pango-debugsource SDL2_Pango-debugsource(x86-64) AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: SDL2_Pango-2.1.4/.pc/am_maintainer_mode.patch/configure.in:53 Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2119499 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Python, SugarActivity, Haskell, Ocaml, PHP, Java, R, Perl, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH $ rpmlint SDL2_Pango-2.1.4-.fc38.src.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 ================= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.2 s ================= $ rpmlint SDL2_Pango-2.1.4-.fc38.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 SDL2_Pango.x86_64: E: incorrect-fsf-address /usr/share/doc/SDL2_Pango/COPYING SDL2_Pango.x86_64: W: incoherent-version-in-changelog 2.1.4-1 ['2.1.4-.fc38', '2.1.4-'] ================= 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken 2.9 s ================= $ rpmlint SDL2_Pango-devel-2.1.4-.fc38.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 SDL2_Pango-devel.x86_64: E: incorrect-fsf-address /usr/include/SDL2_Pango.h ================= 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 1 badness; has taken 0.2 s ================= $ rpmlint SDL2_Pango-debuginfo-2.1.4-.fc38.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 SDL2_Pango-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/lib64/libSDL2_Pango.so.3.1.0-2.1.4-.fc38.x86_64.debug SDL2_Pango-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/lib64/libSDL2_Pango.so.3.1.0-2.1.4-.fc38.x86_64.debug SDL2_Pango-debuginfo.x86_64: W: no-documentation SDL2_Pango-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/32/fd7e33b579c3b4e843b6cd100a293298a34536 ../../../.build-id/32/fd7e33b579c3b4e843b6cd100a293298a34536 ================= 1 packages and 0 specfiles checked; 1 errors, 3 warnings, 1 badness; has taken 0.4 s ================= $ rpmlint SDL2_Pango-debugsource-2.1.4-.fc38.x86_64.rpm ================================================ rpmlint session starts ================================================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 SDL2_Pango-debugsource.x86_64: W: no-documentation SDL2_Pango-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/SDL2_Pango-2.1.4-.fc38.x86_64/src/SDL2_Pango.c SDL2_Pango-debugsource.x86_64: E: incorrect-fsf-address /usr/src/debug/SDL2_Pango-2.1.4-.fc38.x86_64/src/SDL2_Pango.h ================= 1 packages and 0 specfiles checked; 2 errors, 1 warnings, 2 badness; has taken 0.2 s ================= Comments: a) Update of licenses seems needed b) For obsolete commands, maybe a pull request should be made to upstream? c) License check contains: *No copyright* GNU Lesser General Public License, Version 2.1 ------------------------------------------------------------- SDL2_Pango-2.1.4/README.md FSF All Permissive License -------------------------- SDL2_Pango-2.1.4/INSTALL FSF Unlimited License (with License Retention) ---------------------------------------------- SDL2_Pango-2.1.4/m4/ltoptions.m4 SDL2_Pango-2.1.4/m4/ltsugar.m4 SDL2_Pango-2.1.4/m4/ltversion.m4 SDL2_Pango-2.1.4/m4/lt~obsolete.m4 FSF Unlimited License (with License Retention) GNU General Public License v2.0 or later [generated file] -------------------------------------------------------------------------------------------------------- SDL2_Pango-2.1.4/aclocal.m4 SDL2_Pango-2.1.4/test/aclocal.m4 FSF Unlimited License (with License Retention) GNU General Public License, Version 2 ------------------------------------------------------------------------------------ SDL2_Pango-2.1.4/m4/libtool.m4 FSF Unlimited License [generated file] -------------------------------------- SDL2_Pango-2.1.4/configure SDL2_Pango-2.1.4/test/configure GNU General Public License v2.0 or later ---------------------------------------- SDL2_Pango-2.1.4/ltmain.sh GNU General Public License v2.0 or later [generated file] --------------------------------------------------------- SDL2_Pango-2.1.4/compile SDL2_Pango-2.1.4/depcomp SDL2_Pango-2.1.4/missing GNU General Public License v3.0 or later ---------------------------------------- SDL2_Pango-2.1.4/config.guess SDL2_Pango-2.1.4/config.sub GNU Lesser General Public License --------------------------------- SDL2_Pango-2.1.4/docs/html/_s_d_l___pango_8h-source.html GNU Lesser General Public License v2.1 or later ----------------------------------------------- SDL2_Pango-2.1.4/debian/copyright GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)] -------------------------------------------------------------------------------------------- SDL2_Pango-2.1.4/src/SDL2_Pango.c SDL2_Pango-2.1.4/src/SDL2_Pango.h SDL2_Pango-2.1.4/test/testbench.c GNU Lesser General Public License, Version 2.1 ---------------------------------------------- SDL2_Pango-2.1.4/COPYING SDL2_Pango-2.1.4/Wix/COPYING.txt SDL2_Pango-2.1.4/Wix/license.rtf GNU Library General Public License, Version 2.0 ----------------------------------------------- SDL2_Pango-2.1.4/test/COPYING Raised issue: d) Tested builds https://copr.fedorainfracloud.org/coprs/fed500/SDL2_Pango/build/4763275/ failures on armhfp, fedora35 e) Maybe worth adding a smoke test: https://download.copr.fedorainfracloud.org/results/fed500/SDL2_Pango/fedora-rawhide-x86_64/04763275-SDL2_Pango/SDL2_Pango.spec f) Spec file should have a line %license COPYING and %doc line should be change appropriately -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2119499 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
