https://bugzilla.redhat.com/show_bug.cgi?id=2095732 --- Comment #6 from Gwyn Ciesla <gwync@xxxxxxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-] Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: Sources can be downloaded from URI in Source: tag Note: Could not download Source20: https://creativecommons.org/publicdomain/zero/1.0/legalcode.txt See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. fonts: [?]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [?]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://www.wfonts.com/download/data/2017/12/30/segment16c/segment16c.zip : CHECKSUM(SHA256) this package : 38342a30a54deb723dbfa551e24a89ad2c92419445b8c22842f5e44038084d72 CHECKSUM(SHA256) upstream package : 38342a30a54deb723dbfa551e24a89ad2c92419445b8c22842f5e44038084d72 https://www.wfonts.com/download/data/2017/12/30/segment16b/segment16b.zip : CHECKSUM(SHA256) this package : 93b4d9a86a7f879a90c780d523d389f1a2026cd766dd32c851f7796eec765196 CHECKSUM(SHA256) upstream package : 93b4d9a86a7f879a90c780d523d389f1a2026cd766dd32c851f7796eec765196 https://www.wfonts.com/download/data/2017/12/30/segment16a/segment16a.zip : CHECKSUM(SHA256) this package : 3065c53d7f062a078f74a4525d5327d7c8aa02eda58e9080f53184f5f5a53422 CHECKSUM(SHA256) upstream package : 3065c53d7f062a078f74a4525d5327d7c8aa02eda58e9080f53184f5f5a53422 Requires -------- daniel-wikholm-segment16c-fonts (rpmlib, GLIBC filtered): config(daniel-wikholm-segment16c-fonts) fontpackages-filesystem Provides -------- daniel-wikholm-segment16c-fonts: config(daniel-wikholm-segment16c-fonts) daniel-wikholm-segment16c-fonts font(segment16c) metainfo() metainfo(org.fedoraproject.daniel-wikholm-segment16c-fonts.metainfo.xml) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2095732 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, fonts Disabled plugins: Python, Perl, Java, PHP, C/C++, Ocaml, Haskell, SugarActivity, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2095732 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
