https://bugzilla.redhat.com/show_bug.cgi?id=2120396 Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+ --- Comment #4 from Mikel Olasagasti Uranga <mikel@xxxxxxxxxxxxxxx> --- > You can skip the %global tag entry My bad, tag is required in this case. go2rpm package, fedora-review is correct: - The specfile is sane. - License is correct. - Builds successfully in mock. - No rpmlint errors. - %check section passes. - The latest version is packaged. - The package complies with the Packaging Guidelines. Package approved! On import, don't forget to do the following: - Add package to release-monitoring.org - Add package to Koschei - Give go-sig privileges on package - Close the review bug by referencing it in the rpm changelog and/or the Bodhi ticket. (rhbz#BUG_ID) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "BSD 3-Clause License", "BSD 2-Clause License", "MIT License". 66 files have unknown license. Detailed output of licensecheck in /tmp/major/2120396-google- osconfig-agent/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 47 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [-]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/GoogleCloudPlatform/osconfig/archive/20220801.00/osconfig-20220801.00.tar.gz : CHECKSUM(SHA256) this package : 2fe8898c65e4d7d4e69ab158ca7b3ee18dfdd94f56b1f316a9c083b105d33d6b CHECKSUM(SHA256) upstream package : 2fe8898c65e4d7d4e69ab158ca7b3ee18dfdd94f56b1f316a9c083b105d33d6b Requires -------- google-osconfig-agent (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) golang-github-googlecloudplatform-osconfig-devel (rpmlib, GLIBC filtered): go-filesystem golang(cloud.google.com/go/compute/metadata) golang(cloud.google.com/go/osconfig/agentendpoint/apiv1) golang(cloud.google.com/go/osconfig/agentendpoint/apiv1beta) golang(cloud.google.com/go/storage) golang(github.com/GoogleCloudPlatform/guest-logging-go/logger) golang(github.com/golang/mock/gomock) golang(github.com/tarm/serial) golang(github.com/ulikunitz/xz) golang(github.com/ulikunitz/xz/lzma) golang(golang.org/x/crypto/openpgp) golang(golang.org/x/crypto/openpgp/armor) golang(golang.org/x/crypto/openpgp/packet) golang(golang.org/x/oauth2/jws) golang(golang.org/x/sys/unix) golang(google.golang.org/api/option) golang(google.golang.org/genproto/googleapis/cloud/osconfig/agentendpoint/v1) golang(google.golang.org/genproto/googleapis/cloud/osconfig/agentendpoint/v1beta) golang(google.golang.org/genproto/googleapis/rpc/errdetails) golang(google.golang.org/genproto/googleapis/type/date) golang(google.golang.org/grpc) golang(google.golang.org/grpc/codes) golang(google.golang.org/grpc/credentials) golang(google.golang.org/grpc/status) golang(google.golang.org/protobuf/encoding/protojson) golang(google.golang.org/protobuf/proto) golang(google.golang.org/protobuf/types/known/timestamppb) google-osconfig-agent-debuginfo (rpmlib, GLIBC filtered): google-osconfig-agent-debugsource (rpmlib, GLIBC filtered): Provides -------- google-osconfig-agent: google-osconfig-agent google-osconfig-agent(x86-64) golang-github-googlecloudplatform-osconfig-devel: golang(github.com/GoogleCloudPlatform/osconfig/agentconfig) golang(github.com/GoogleCloudPlatform/osconfig/agentconfig)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/agentendpoint) golang(github.com/GoogleCloudPlatform/osconfig/agentendpoint)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/attributes) golang(github.com/GoogleCloudPlatform/osconfig/attributes)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/clog) golang(github.com/GoogleCloudPlatform/osconfig/clog)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/config) golang(github.com/GoogleCloudPlatform/osconfig/config)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/external) golang(github.com/GoogleCloudPlatform/osconfig/external)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/inventory) golang(github.com/GoogleCloudPlatform/osconfig/inventory)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/osinfo) golang(github.com/GoogleCloudPlatform/osconfig/osinfo)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/ospatch) golang(github.com/GoogleCloudPlatform/osconfig/ospatch)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/packages) golang(github.com/GoogleCloudPlatform/osconfig/packages)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/policies) golang(github.com/GoogleCloudPlatform/osconfig/policies)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/policies/recipes) golang(github.com/GoogleCloudPlatform/osconfig/policies/recipes)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/pretty) golang(github.com/GoogleCloudPlatform/osconfig/pretty)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/retryutil) golang(github.com/GoogleCloudPlatform/osconfig/retryutil)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/tasker) golang(github.com/GoogleCloudPlatform/osconfig/tasker)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/util) golang(github.com/GoogleCloudPlatform/osconfig/util)(tag=20220801.00) golang(github.com/GoogleCloudPlatform/osconfig/util/mocks) golang(github.com/GoogleCloudPlatform/osconfig/util/mocks)(tag=20220801.00) golang-github-googlecloudplatform-osconfig-devel golang-ipath(github.com/GoogleCloudPlatform/osconfig) golang-ipath(github.com/GoogleCloudPlatform/osconfig)(tag=20220801.00) google-osconfig-agent-debuginfo: debuginfo(build-id) google-osconfig-agent-debuginfo google-osconfig-agent-debuginfo(x86-64) google-osconfig-agent-debugsource: google-osconfig-agent-debugsource google-osconfig-agent-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2120396 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Perl, C/C++, Java, Python, R, fonts, SugarActivity, Ocaml, Haskell, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2120396 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
