[Bug 2098373] Review Request: gearhead2 - Roguelike mecha role-playing game in space

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2098373



--- Comment #3 from Benson Muite <benson_muite@xxxxxxxxxxxxx> ---
Programs seems to run. May want to package the doc directory
https://github.com/jwvhewitt/gearhead-2/tree/master/doc

Some linting messages below. Incorrect address might be something that can be
fixed upstream. Is it possible to generate a PIC executable?  What about the
statically linked errors?

$ rpmlint gearhead2-0.701-1.20201130git86d17e1.fc36.src.rpm 
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2.spec:151: W: mixed-use-of-spaces-and-tabs (spaces: line 151, tab:
line 147)
 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken
1.7 s 

$ rpmlint gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2.x86_64: W: no-documentation
gearhead2.x86_64: E: no-binary
 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken
0.3 s 

$ rpmlint gearhead2-data-0.701-1.20201130git86d17e1.fc37.noarch.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2-data.noarch: E: incorrect-fsf-address
/usr/share/licenses/gearhead2-data/license.txt
gearhead2-data.noarch: W: files-duplicate
/usr/share/gearhead2/series/ARENAMISSION_Police.txt
/usr/share/gearhead2/series/ARENAMISSION_Criminal.txt
 1 packages and 0 specfiles checked; 1 errors, 1 warnings, 1 badness; has taken
0.8 s

$ rpmlint gearhead2-data-gfx-0.701-1.20201130git86d17e1.fc37.noarch.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2-data-gfx.noarch: W: no-documentation
gearhead2-data-gfx.noarch: W: dangling-symlink
/usr/share/gearhead2/image/VeraBd.ttf
/usr/share/fonts/bitstream-vera-sans-fonts/VeraBd.ttf
gearhead2-data-gfx.noarch: W: dangling-symlink
/usr/share/gearhead2/image/VeraMoBd.ttf
/usr/share/fonts/bitstream-vera-sans-mono-fonts/VeraMoBd.ttf
 1 packages and 0 specfiles checked; 0 errors, 3 warnings, 0 badness; has taken
1.0 s

$ rpmlint gearhead2-debuginfo-0.701-1.20201130git86d17e1.fc37.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/.dwz/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64
gearhead2-debuginfo.x86_64: E: statically-linked-binary
/usr/lib/debug/.dwz/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64
gearhead2-debuginfo.x86_64: W: no-documentation
gearhead2-debuginfo.x86_64: E: missing-PT_GNU_STACK-section
/usr/lib/debug/.dwz/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64
gearhead2-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
gearhead2-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz
 1 packages and 0 specfiles checked; 2 errors, 4 warnings, 2 badness; has taken
0.7 s

$ rpmlint gearhead2-debugsource-0.701-1.20201130git86d17e1.fc37.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2-debugsource.x86_64: W: no-documentation
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ability.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/aibrain.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/arenacfe.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/arenaplay.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/backpack.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/chargen.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/colormenu.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/customization.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/description.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/gearhead2.pas
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/gearparser.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/gears.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/gearutil.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghchars.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghguard.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghholder.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghintrinsic.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghmecha.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghmovers.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghsensor.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghswag.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ghweapon.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/grabgear.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/infodisplay.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/locale.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/menugear.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/minigame.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/minitype.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/mpbuilder.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/narration.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/navigate.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/pcaction.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/robotics.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/rpgdice.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/sdlgfx.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/sdlinfo.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/sdlmap.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/sdlmenus.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/services.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/specialsys.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/targetui.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/texutil.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/training.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/ui4gh.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/vidgfx.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/vidinfo.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/vidmap.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/vidmenus.pp
gearhead2-debugsource.x86_64: E: incorrect-fsf-address
/usr/src/debug/gearhead2-0.701-1.20201130git86d17e1.fc37.x86_64/wmonster.pp
 1 packages and 0 specfiles checked; 49 errors, 1 warnings, 49 badness; has
taken 0.5 s

$ rpmlint gearhead2-SDL-0.701-1.20201130git86d17e1.fc37.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2-SDL.x86_64: W: position-independent-executable-suggested
/usr/bin/gearhead2-sdl
gearhead2-SDL.x86_64: W: no-manual-page-for-binary gearhead2-sdl
gearhead2-SDL.x86_64: W: no-documentation
gearhead2-SDL.x86_64: W: description-shorter-than-summary
 1 packages and 0 specfiles checked; 0 errors, 4 warnings, 0 badness; has taken
249.9 s

$ rpmlint gearhead2-SDL-debuginfo-0.701-1.20201130git86d17e1.fc37.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2-SDL-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/usr/bin/gearhead2-sdl-0.701-1.20201130git86d17e1.fc37.x86_64.debug
gearhead2-SDL-debuginfo.x86_64: E: statically-linked-binary
/usr/lib/debug/usr/bin/gearhead2-sdl-0.701-1.20201130git86d17e1.fc37.x86_64.debug
gearhead2-SDL-debuginfo.x86_64: W: position-independent-executable-suggested
/usr/lib/debug/usr/bin/gearhead2-sdl-0.701-1.20201130git86d17e1.fc37.x86_64.debug
gearhead2-SDL-debuginfo.x86_64: W: no-documentation
gearhead2-SDL-debuginfo.x86_64: W: dangling-relative-symlink
/usr/lib/debug/.build-id/40/b443ec0cf04cab227195f3de43ed190c145ab0
../../../.build-id/40/b443ec0cf04cab227195f3de43ed190c145ab0
 1 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken
34.3 s

$ rpmlint gearhead2-textmode-0.701-1.20201130git86d17e1.fc37.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2-textmode.x86_64: E: statically-linked-binary
/usr/bin/gearhead2-textmode
gearhead2-textmode.x86_64: W: position-independent-executable-suggested
/usr/bin/gearhead2-textmode
gearhead2-textmode.x86_64: W: no-manual-page-for-binary gearhead2-textmode
gearhead2-textmode.x86_64: W: no-documentation
gearhead2-textmode.x86_64: W: description-shorter-than-summary
 1 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken
2.5 s

$ rpmlint
gearhead2-textmode-debuginfo-0.701-1.20201130git86d17e1.fc37.x86_64.rpm
============================ rpmlint session starts
============================
rpmlint: 2.2.0
configuration:
    /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/licenses.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

gearhead2-textmode-debuginfo.x86_64: W: unstripped-binary-or-object
/usr/lib/debug/usr/bin/gearhead2-textmode-0.701-1.20201130git86d17e1.fc37.x86_64.debug
gearhead2-textmode-debuginfo.x86_64: E: statically-linked-binary
/usr/lib/debug/usr/bin/gearhead2-textmode-0.701-1.20201130git86d17e1.fc37.x86_64.debug
gearhead2-textmode-debuginfo.x86_64: W:
position-independent-executable-suggested
/usr/lib/debug/usr/bin/gearhead2-textmode-0.701-1.20201130git86d17e1.fc37.x86_64.debug
gearhead2-textmode-debuginfo.x86_64: W: no-documentation
gearhead2-textmode-debuginfo.x86_64: W: dangling-relative-symlink
/usr/lib/debug/.build-id/68/24ce97de3eea44232e005c4d799fddbf11b7be
../../../.build-id/68/24ce97de3eea44232e005c4d799fddbf11b7be
 1 packages and 0 specfiles checked; 1 errors, 4 warnings, 1 badness; has taken
1.1 s


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2098373
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux