https://bugzilla.redhat.com/show_bug.cgi?id=2120139 --- Comment #3 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- > a) May need Unicode license, license check has the following output: > Unicode strict > -------------- > simpleini-4.19/ConvertUTF.c > simpleini-4.19/ConvertUTF.h > Maybe upstream could use something that is being actively maintained? The > unicode consortium no longer updates this. Added license as "Unicode" for now. It's not listed with SPDX but it is an approved Fedora license per https://fedoraproject.org/wiki/Licensing/Unicode. I'm going to work on its inclusion to SPDX but I don't think that should hold up this package. > b) To run the tests, one needs to use > make test > not > make tests `make -C tests` as written is executing the Makefile in the tests directory. There are no test definitions in the main directory so `make test` does not work. Spec URL: https://jonathanspw.fedorapeople.org/simpleini.spec SRPM URL: https://jonathanspw.fedorapeople.org/simpleini-4.19-1.fc38.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2120139 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
