https://bugzilla.redhat.com/show_bug.cgi?id=2120002 --- Comment #3 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- (In reply to Artur Frenszek-Iwicki from comment #2) > > Spec URL: https://jonathanspw.fedoraproject.org/cinfo.spec > > SRPM URL: https://jonathanspw.fedoraproject.org/cinfo-0.4.6-1.fc38.src.rpm > Both of these give me a 404. I assume you meant to use fedorapeople.org > links, not fedoraproject.org? > The files exist there. Doh. > > BuildRequires: gcc > You need to BuildRequire "make" as well. It hasn't been part of the default > buildroot since F34. > https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot Fixed > > %build > > %set_build_flags > This is not needed. %set_build_flags is called automatically from F36 > onwards. > https://fedoraproject.org/wiki/Changes/SetBuildFlagsBuildCheck It's needed for F35 and all EPEL. I'm happy to wrap it in an %if block if you think it necessary but it seems unnecessary to me. --- Spec URL: https://jonathanspw.fedorapeople.org/cinfo.spec SRPM URL: https://jonathanspw.fedorapeople.org/cinfo-0.4.6-1.fc38.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120002 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
