https://bugzilla.redhat.com/show_bug.cgi?id=2120272 --- Comment #2 from Kalev Lember <klember@xxxxxxxxxx> --- Thanks Benson for taking the review! (In reply to Benson Muite from comment #1) > fedora-review gives the following issues (probably automatically updates > spec file is used): > > Issues: > ======= > - If (and only if) the source package includes the text of the license(s) > in its own file, then that file, containing the text of the license(s) > for the package is included in %license. > Note: License file shumate-license.h is not marked as %license > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/LicensingGuidelines/#_license_text This is just bogus. The spec file already includes COPYING as %license. shumate-license.h that fedora-review is suggesting to use as %license is something completely different. > - Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 2856960 bytes in 345 files. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/#_documentation Sure, let me split that out. > Diff spec file in url and in SRPM > --------------------------------- > --- /home/FedoraPackaging/libshumate/2120272-libshumate/srpm/libshumate.spec > 2022-08-22 16:59:13.465597447 +0300 > +++ > /home/FedoraPackaging/libshumate/2120272-libshumate/srpm-unpacked/libshumate. > spec 2022-08-22 14:50:46.000000000 +0300 > @@ -1,2 +1,11 @@ > +## START: Set by rpmautospec > +## (rpmautospec version 0.3.0) > +%define autorelease(e:s:pb:n) %{?-p:0.}%{lua: > + release_number = 1; > + base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); > + print(release_number + base_release_number - 1); > +}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} > +## END: Set by rpmautospec > + > %global tarball_version %%(echo %{version} | tr '~' '.') > > @@ -72,3 +81,4 @@ > > %changelog > -%autochangelog > +* Mon Aug 22 2022 Kalev Lember <klember@xxxxxxxxxx> 1.0.0~alpha.1-1 > +- Initial Fedora packaging This is just fedora-review not knowing how to handle rpmautospec. > Licenses used seem to be: > GNU Lesser General Public License, Version 2.1 Where did you see this? I can't find any files that are LGPL-2.0-only? > GNU Lesser General Public License v2.1 or later > GNU Library General Public License v2 or later Ah, yes, looks like shumate/shumate-viewport.c and shumate/shumate-viewport.h are LGPL-2.0-or-later while the rest of the code is LGPL-2.1-or-later. Let me update the license field to reflect that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2120272 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
