https://bugzilla.redhat.com/show_bug.cgi?id=2105993 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > License > FIX: We have new licensing guidelines. Please write a license tag value in > SPDX syntax > $ license-fedora2spdx "Artistic 2.0" > Artistic-2.0 -License: Artistic 2.0 +License: Artistic-2.0 Done > BuildRequires > FIX: Please add build-requires: > coreutils - needed for macro %{_fixperms} +BuildRequires: coreutils Done > TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. -BuildRequires: perl(ExtUtils::MakeMaker) >= 6.64 +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Done > FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46. -%{__perl} Makefile.PL INSTALLDIRS=vendor INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 +%{__perl} Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1 Done The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2105993 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
