https://bugzilla.redhat.com/show_bug.cgi?id=2103418 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- > License > FIX: We have new licensing guidelines. Please write a license tag value in > SPDX syntax > https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages > $ license-fedora2spdx "GPL+ or Artistic" > GPL-1.0-or-later OR Artistic-1.0-Perl -License: GPL+ or Artistic +License: GPL-1.0-or-later OR Artistic-1.0-Perl Done > BuildRequires > FIX: Please add build-requires: > coreutils - needed for macro %{_fixperms} > perl(Class::Tiny) - t/02roletiny.t:6, t/06rolebasic.t:6 > perl(lib) - t/07mite.t:10 > perl(Moo::Role) - t/03moorole.t:6 > perl(Moose::Role) - t/04mooserole.t:6 > perl(Mouse::Role) - t/05mouserole.t:6 > perl(Role::Tiny) - t/02roletiny.t:5 > perl(Role::Tiny::With) - t/02roletiny.t:42 Done > TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 > NO_PACKLIST is provided since this version. -BuildRequires: perl(ExtUtils::MakeMaker) +BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 Done > Binary requires > FIX: Please add run-require: > perl(Carp) - lib/Role/Hooks.pm:24,30,36 +# Not sure, if this dep should be mandatory +Recommends: perl(Carp) Done The package is in line with Fedora and Perl packaging guide lines. Resolution: Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2103418 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
