https://bugzilla.redhat.com/show_bug.cgi?id=2118887 Lyes Saadi <fedora@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Lyes Saadi <fedora@xxxxxxx> --- Package Approved! Please check notes for some minor nitpicking. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Notes ===== - Please add the link to the PR for the alma-linux patch as a comment: https://github.com/LinusDierheimer/fastfetch/pull/214 - Capitalize the summary of fastfetch-bash-completion - rpmlint asks to port the code to getaddrinfo instead of gethostbyname. Maybe report that to the developper? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 140 files have unknown license. Detailed output of licensecheck in /home/lyes/Documents/reviews/2118887-fastfetch/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in fastfetch-bash-completion [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- rpmlint: 2.2.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 fastfetch-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/.dwz/fastfetch-1.6.3-1.fc38.x86_64 fastfetch-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/fastfetch-1.6.3-1.fc38.x86_64.debug fastfetch-debuginfo.x86_64: W: unstripped-binary-or-object /usr/lib/debug/usr/bin/flashfetch-1.6.3-1.fc38.x86_64.debug fastfetch-bash-completion.noarch: W: summary-not-capitalized bash completion files for fastfetch fastfetch-debuginfo.x86_64: E: statically-linked-binary /usr/lib/debug/.dwz/fastfetch-1.6.3-1.fc38.x86_64 fastfetch-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/fastfetch-1.6.3-1.fc38.x86_64.debug fastfetch-debuginfo.x86_64: E: shared-library-without-dependency-information /usr/lib/debug/usr/bin/flashfetch-1.6.3-1.fc38.x86_64.debug fastfetch-bash-completion.noarch: E: non-executable-script /usr/share/bash-completion/completions/fastfetch 644 /usr/bin/env bash fastfetch.x86_64: W: no-manual-page-for-binary fastfetch fastfetch.x86_64: W: no-manual-page-for-binary flashfetch fastfetch-bash-completion.noarch: W: no-documentation fastfetch-debuginfo.x86_64: W: no-documentation fastfetch-debugsource.x86_64: W: no-documentation fastfetch-debuginfo.x86_64: E: missing-PT_GNU_STACK-section /usr/lib/debug/.dwz/fastfetch-1.6.3-1.fc38.x86_64 fastfetch-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz fastfetch-debuginfo.x86_64: W: hidden-file-or-dir /usr/lib/debug/.dwz fastfetch-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/cd/af0d4e839751a128b26f25996d7272989ceb92 ../../../.build-id/cd/af0d4e839751a128b26f25996d7272989ceb92 fastfetch-debuginfo.x86_64: W: dangling-relative-symlink /usr/lib/debug/.build-id/e0/0943041eeb8e86d8db7b64eba0fa4ea1f28a81 ../../../.build-id/e0/0943041eeb8e86d8db7b64eba0fa4ea1f28a81 fastfetch.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/fastfetch fastfetch.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/bin/flashfetch fastfetch-debuginfo.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib/debug/usr/bin/fastfetch-1.6.3-1.fc38.x86_64.debug Note: Everything can be ignored except binary-or-shlib-calls-gethostbyname Source checksums ---------------- https://github.com/LinusDierheimer/fastfetch/archive/1.6.3/fastfetch-1.6.3.tar.gz : CHECKSUM(SHA256) this package : 3c70531fdc52f36e1fa0a69f99a6b923fce6f775546525e0ad6ff6908365073c CHECKSUM(SHA256) upstream package : 3c70531fdc52f36e1fa0a69f99a6b923fce6f775546525e0ad6ff6908365073c Requires -------- fastfetch (rpmlib, GLIBC filtered): config(fastfetch) libc.so.6()(64bit) rtld(GNU_HASH) fastfetch-bash-completion (rpmlib, GLIBC filtered): bash-completion fastfetch fastfetch-debuginfo (rpmlib, GLIBC filtered): fastfetch-debugsource (rpmlib, GLIBC filtered): Provides -------- fastfetch: config(fastfetch) fastfetch fastfetch(x86-64) fastfetch-bash-completion: fastfetch-bash-completion fastfetch-debuginfo: debuginfo(build-id) fastfetch-debuginfo fastfetch-debuginfo(x86-64) fastfetch-debugsource: fastfetch-debugsource fastfetch-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2118887 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: fonts, Haskell, PHP, Python, Ocaml, SugarActivity, Perl, Java, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2118887 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
