https://bugzilla.redhat.com/show_bug.cgi?id=2118835 --- Comment #4 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- > a) Packaging qsort separately as a header only library would be helpful. It would make it easier to find. It is also in a separate repository, https://github.com/svpv/qsort and seems to be developed separately. It should be packaged as a static library https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries - clifm can also use the slower system qsort I've submitted https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2120099. In the meantime I'll use system qsort (which is was actually doing already anyway). An extra flag is required to enable the included qsort so when the review above is complete I'll have to create a patch to use it and I'll submit that patch upstream of course. > b) Licensing needs more explanation, may be good to list licenses used on each file. Doing each file would be a bit elaborate IMO. Luckily the breakdown is pretty well defined by directory so I added a source directory breakdown for things that go into the resulting package. > c) The build log contains some warnings about possible memory overflows: I'm not really sure what I can do about this as a packager but I'll do some research on the topic and report it to upstream. Spec URL: https://jonathanspw.fedorapeople.org/clifm.spec SRPM URL: https://jonathanspw.fedorapeople.org/clifm-1.6-1.fc38.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2118835 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
