https://bugzilla.redhat.com/show_bug.cgi?id=2119983 --- Comment #2 from Simone Caronni <negativo17@xxxxxxxxx> --- Spec URL: https://slaanesh.fedorapeople.org/c-icap.spec SRPM URL: https://slaanesh.fedorapeople.org/c-icap-0.5.10-5.fc36.src.rpm Thanks for the review! I fixed everything except these: (In reply to Jonathan Wright from comment #1) > Personally I'd use GitHub for the source URL here, mainly due to the "0.5.x" > part of the URL which will require updating in the future whereas a GH URL > can use all variables. That would be my preference as well, but unfortunately the Github tags are not there for the c-icap-modules counterpart, so I would need to rely there anyway on the SF links. For consistency I've left the tarball URL pointing to SF as described in their release page. > > BuildRequires: libdb-devel > > This package is deprecated so you cannot depend on it. [4] I know there can't be newer versions in Fedora/EPEL due to licensing reasons (hit the same with the bitcoin-core review, where I had to bundle it in the package), but the package is not deprecated: https://src.fedoraproject.org/rpms/libdb/tree/rawhide It's also in the base repositories of el7, 8 and 9, so still fully supported at the moment. > The old changelog from other folks is probably not needed. The %changelog > section is really to show a package's history in Fedora to represent > potential user-impacting changes so anything before it became a package > isn't really relevant. [6] I've left the versions intact as this should update the packages at https://copr.fedorainfracloud.org/coprs/frankcrawford/c-icap/, I will maintain this package along the owner of that COPR repository. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2119983 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
