Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: tpm-tools - TPM management utilities https://bugzilla.redhat.com/show_bug.cgi?id=394941 ------- Additional Comments From mtasaka@xxxxxxxxxxxxxxxxxxx 2007-12-14 10:23 EST ------- For 1.3.1-2: * SourceURL - Perhaps the correct one is http://downloads.sourceforge.net/trousers/%{name}-%{version}.tar.gz * Redundant Requires A. "Requires: trousers" is not needed - rpmbuild checks the dependency for libraries. For this package tpm-tools binary rpm requires libtspi.so.1 and this dependency should pull trousers automatically. B. Requires(post/postun): /sbin/ldconfig For this package this is not needed because ------------------------------------------------------------- %post -p /sbin/ldconfig %postun -p /sbin/ldconfig ------------------------------------------------------------- automatically adds these dependencies. ? configure option - (This is a question) Would you explain why you want "--disable-pkcs11-support"? * Directory ownership issue -------------------------------------------------------------- %files devel %{_includedir}/tpm_tools/*.h -------------------------------------------------------------- - This causes -------------------------------------------------------------- [tasaka1@localhost ~]$ LANG=C rpm -qf /usr/include/tpm_tools/ file /usr/include/tpm_tools is not owned by any package -------------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review