https://bugzilla.redhat.com/show_bug.cgi?id=2025398 Jakub Kadlčík <jkadlcik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value CC| |jkadlcik@xxxxxxxxxx --- Comment #1 from Jakub Kadlčík <jkadlcik@xxxxxxxxxx> --- Hello Link, thank you for the package. I tried to run it and it worked for me. The spec file is well-written as well. I have only a couple of suggestions. > Patch0: fix-makefile.patch > Patch1: silence-const-char-errors.patch We try to be upstream-first, can you please submit those patches as pull requests, and link them in the spec as comments? Then we can easily check if they are merged and that we can drop the custom patches. If upstream is not interested in such changes and won't merge, at least we tried and have justification for maintaining those patches here. > %global commit 535ad7fc57378025757461dcb582db8b4c944564 > %global forgeurl https://github.com/linappleii/linapple > Version: 0 I am looking at https://github.com/linappleii/linapple/blob/master/CHANGELOG and I think the current version is 2.1 So maybe we should package from this commit https://github.com/linappleii/linapple/commit/c78c192141f5024f7c8618992d71754231cbff71 or maybe some other commit, that marks the 2.1 version? It's from 2017 though, if we need some newer version, can you please ask upstream to create a new release? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2025398 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
