https://bugzilla.redhat.com/show_bug.cgi?id=2105993 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Doc Type|--- |If docs needed, set a value Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx CC| |jplesnik@xxxxxxxxxx --- Comment #1 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax $ license-fedora2spdx "Artistic 2.0" Artistic-2.0 Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires: coreutils - needed for macro %{_fixperms} TODO: Please increase version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-Data-Constraint-1.203-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(base) 1 perl(Class::Prototyped) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(strict) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Data-Constraint-1.203-1.fc38.noarch.rpm | sort | uniq -c 1 perl(Data::Constraint) = 1.203 1 perl-Data-Constraint = 1.203-1.fc38 Binary provides are Ok. $ rpmlint ./perl-Data-Constraint* =========================== rpmlint session starts =========================== rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint is ok FIX: Please remove duplicity of 'INSTALLDIRS=vendor' on line 46. Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2105993 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
