https://bugzilla.redhat.com/show_bug.cgi?id=2103418 Jitka Plesnikova <jplesnik@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jplesnik@xxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jplesnik@xxxxxxxxxx Flags| |fedora-review? --- Comment #2 from Jitka Plesnikova <jplesnik@xxxxxxxxxx> --- Source file is ok Summary is ok License FIX: We have new licensing guidelines. Please write a license tag value in SPDX syntax https://docs.fedoraproject.org/en-US/legal/license-field/#_perl_packages $ license-fedora2spdx "GPL+ or Artistic" GPL-1.0-or-later OR Artistic-1.0-Perl Description is ok URL and Source0 are ok All tests passed BuildRequires FIX: Please add build-requires: coreutils - needed for macro %{_fixperms} perl(Class::Tiny) - t/02roletiny.t:6, t/06rolebasic.t:6 perl(lib) - t/07mite.t:10 perl(Moo::Role) - t/03moorole.t:6 perl(Moose::Role) - t/04mooserole.t:6 perl(Mouse::Role) - t/05mouserole.t:6 perl(Role::Tiny) - t/02roletiny.t:5 perl(Role::Tiny::With) - t/02roletiny.t:42 TODO: Please add version restriction for perl(ExtUtils::MakeMaker) >= 6.76 NO_PACKLIST is provided since this version. $ rpm -qp --requires perl-Role-Hooks-0.008-1.fc38.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Class::Method::Modifiers) 1 perl(:MODULE_COMPAT_5.36.0) 1 perl(strict) 1 perl(:VERSION) >= 5.8.1 1 perl(warnings) Binary requires FIX: Please add run-require: perl(Carp) - lib/Role/Hooks.pm:24,30,36 $ rpm -qp --provides perl-Role-Hooks-0.008-1.fc38.noarch.rpm | sort | uniq -c 1 perl(Role::Hooks) = 0.008 1 perl-Role-Hooks = 0.008-1.fc38 Binary provides are Ok. $ rpmlint ./perl-Role-Hooks* ============================ rpmlint session starts ============================ rpmlint: 2.2.0 configuration: /usr/lib/python3.10/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/licenses.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint is ok Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct all 'FIX' items, consider fixing 'TODO' item and provide a new spec file. Resolution: Not Approved -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2103418 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
