https://bugzilla.redhat.com/show_bug.cgi?id=1983890 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? --- Comment #7 from Fabio Valentini <decathorpe@xxxxxxxxx> --- I just noticed that the project doesn't contain a full copy of the Apache-2.0 license text but only includes the license header for Apache-2.0 in LICENSE.md. I'm pretty sure that this is not acceptable :( Other than that, the package looks good to me now, thanks. ====== Keep in mind that you can include a rust2rpm.conf file to automatically include the Build/Requires for sqlite-devel with: ``` [DEFAULT] buildrequires = pkgconfig(sqlite3) lib.requires = pkgconfig(sqlite3) ``` The runtime requires ("Requires: pkgconfig(sqlite3)") is currently missing from the package, using a rust2rpm.conf file in the future will prevent that from happening by mistake. === I also wonder how this crate actually works, given that the sources are empty. Does it only exist to link against libsqlite3 and serves no other purpose? The bindings seem to be in sqlite3-sys, instead ... weird setup. Most projects do this in the same crate, but if it works :shrug: -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=1983890 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
