https://bugzilla.redhat.com/show_bug.cgi?id=2116065 --- Comment #5 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Two non-blocking comments: 1. Please make sure to regenerate .spec files with rust2rpm for *every* new version. For example, this line is no longer correct: # Upstream license specification: MIT/Apache-2.0 As the upstream crate metadata has updated the license string to use "OR" instead of the deprecated "/" SPDX syntax. If you don't re-run rust2rpm for new versions, it can result in broken packages (for example, if features or optional dependencies change, the generated subpackages for those features / optional dependencies will be outdated, and will have broken dependencies, or will be missing). 2. Make sure you don't "fedpkg import" the SRPM file that you uploaded for this review. It was already munged by rpmautospec. PS: I tend to build SRPM files for review requests with "rpmbuild -bs", which doesn't expand those macros, and creates SRPM files that are safe to be imported with "fedpkg import". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2116065 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
