https://bugzilla.redhat.com/show_bug.cgi?id=2116066 Fabio Valentini <decathorpe@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |decathorpe@xxxxxxxxx Flags| |fedora-review? Status|NEW |ASSIGNED --- Comment #4 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Looks like you didn't regenerate the spec file with rust2rpm for 0.3.2? > # Upstream license specification: MIT/Apache-2.0 This line is no longer generated, it looks like upstream changed this to "MIT OR Apache-2.0" with v0.3.2. Another (small) issue is the overly long Summary tag. Please shorten it so sensible length, something like Summary: Estimation of the number of primes below n and the k-th prime instead of Summary: State-of-the-art estimation of upper and lower bounds for π(n) (the number of primes below n) and p_k (the k-th prime) The summary shouldn't be longer than ~70 characters. Other than that, the package looks good, and I'll approve it once those two are cleaned up. PS: Please make sure you don't "fedpkg import" the SRPM file that you uploaded, but either copy the files manually into the new dist-git repo, or rebuild the SRPM with "rpmbuild -bs" first (which doesn't mangle rpmautospec macros). -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2116066 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
