Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: g2clib - GRIB2 encoder/decoder and search/indexing routines in C https://bugzilla.redhat.com/show_bug.cgi?id=257741 bugzilla@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Version|devel |rawhide orion@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx OtherBugsDependingO| |381241 nThis| | AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orion@xxxxxxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review- ------- Additional Comments From orion@xxxxxxxxxxxxx 2007-12-13 23:55 EST ------- Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files I went ahead and updated to 1.0.5: http://www.cora.nwra.com/~orion/fedora/g2clib-1.0.5-1.fc8.src.rpm Question: License is listed as Public Domain. I agree that this is probably the case as it is US Gov. work, but there seems to be absolutely no mention of this anywhere in the source. Not sure if this is necessary for public domain. CC'ing Spot for clarification. Does upstream has any interest in supporting building shared libraries? Otherwise, everything looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review