[Bug 2112474] Review Request: python-qemu-qmp - QEMU Monitor Protocol library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=2112474



--- Comment #32 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
(In reply to Maxwell G from comment #31)
> If you change your mind about the qmp-tui thing, here's how you'd split it
> into a subpackage:
> 
> ```
> %package        -n python3-qemu-qmp-tui
> Summary:        Summary here
> Requires:       python3-qemu-qmp = %{version}-%{release}
> Requires:       python3dist(urwid)
> Requires:       python3dist(pygments)
> Requires:       python3dist(urwid)
> 
> %description    -n python3-qemu-qmp-tui %_description
> 
> Subpackage specific description here
> 
> 
> [...]
> 
> %files -n python3-qemu-qmp-tui
> # The licenses do not need to be included in this subpackage,
> # as it directly depends on the base package which includes them.
> %{_bindir}/qmp-tui
> ```


Looking at
https://gitlab.com/qemu-project/python-qemu-qmp/-/blob/v0.0.1/setup.cfg#L61
there is no need to list the dependencies manually.

You can do this instead:


%pyproject_extras_subpkg -n python3-qemu-qmp tui
%{_bindir}/qmp-tui



Or, assuming you want custom description/summary/provides:


%package        -n python3-qemu-qmp+tui
Summary:        Summary here
Requires:       python3-qemu-qmp = %{version}-%{release}
Provides:       qmp-tui = %{version}-%{release}

%description    -n python3-qemu-qmp+tui %_description

Subpackage specific description here


[...]

%files -n python3-qemu-qmp+tui
%ghost %{python3_sitelib}/*.dist-info
%{_bindir}/qmp-tui


-- 
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2112474
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux