https://bugzilla.redhat.com/show_bug.cgi?id=2117772 Alessio <alciregi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(alciregi@posteo.n | |et) | --- Comment #4 from Alessio <alciregi@xxxxxxxxxx> --- First of all, thank you. (In reply to Jonathan Wright from comment #3) > Comments > ------------ > 1. Add `COPYING` to %license OK > 2. I'd personally remove the old changelog that never made it into Fedora. > Just start it with yours. OK > 3. `INSTALL` should not be packaged as documentation - > https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Yep. > 4. You need to add a %check section. Upstream includes tests so we need to > run them. A few of them will fail inside of mock and will need to be > excluded but we should run what we can. > I did this with a simple section like this between %build and %install: > > ``` > %check > make check > ``` The point is also that the tool should run as privileged users. So, while i.e. sudo ./tests/sanity works, ./tests/sanity doesn't I will exclude all the failing ones. Could be ok? > 5. This looks like a super handy tool. Please package it for epel8 and > epel9 once approved ;) It builds on both. Sure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2117772 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
