https://bugzilla.redhat.com/show_bug.cgi?id=2112639 --- Comment #5 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Issues to be fixed: 1) rpmlint output on generated rpms shows pt-astra-sans-fonts.noarch: W: incoherent-version-in-changelog 1.001-2 ['1.001-1.fc37', '1.001-1'] ==> Fix Release tag, Changelog is correct 2) SPEC file name should be pt-astra-sans-fonts.spec 3) As there is no direct downloadable link for LICENSE.txt, just add as comment to Source11 that that file is taken from https://astralinux.ru/en/ofl as # https://astralinux.ru/en/ofl Source11: LICENSE.txt 4) I will suggest to keep %prep section as simple as %prep %setup -q -c and then list font files as %global fonts PTAstraSans_TTF_ver1001/*.ttf this will fix adding the ttf files in the binary rpm. Similar changes needed for other package review #2112636 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Spec file name must match the spec package %{name}, in the format %{name}.spec. Note: PTAstraSans.spec should be pt-astra-sans-fonts.spec See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_spec_file_naming ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. No licenses found. Please check the source files for licenses manually. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/test/2112639-PTAstraSans/srpm- unpacked/PTAstraSans.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). fonts: [!]: Run repo-font-audit on all fonts in package. Note: Cannot find repo-font-audit, install fontpackages-tools package to make a comprehensive font review. See: url: undefined [!]: Run ttname on all fonts in package. Note: Cannot find ttname command, install ttname package to make a comprehensive font review. See: url: undefined Rpmlint ------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://astralinux.ru/information/fonts-astra/font-ptastrasans-ttf-ver1001.zip : CHECKSUM(SHA256) this package : f03af6c31fb1ab225d0d06f955bb5d9bd8d2819a1c8b1c49ea33040d31674be6 CHECKSUM(SHA256) upstream package : f03af6c31fb1ab225d0d06f955bb5d9bd8d2819a1c8b1c49ea33040d31674be6 Requires -------- pt-astra-sans-fonts (rpmlib, GLIBC filtered): config(pt-astra-sans-fonts) fontpackages-filesystem Provides -------- pt-astra-sans-fonts: config(pt-astra-sans-fonts) metainfo() metainfo(org.fedoraproject.pt-astra-sans-fonts.metainfo.xml) pt-astra-sans-fonts Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2112639 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, fonts Disabled plugins: Java, R, C/C++, Perl, Ocaml, Python, PHP, SugarActivity, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2112639 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
