https://bugzilla.redhat.com/show_bug.cgi?id=2117046 --- Comment #9 from Stansoft <rpm@xxxxxxxxxxxx> --- (In reply to Jonathan Wright from comment #8) > You need a `BuildRequires: gcc`. [1] Added > > > Requires(pre): shadow-utils > > Is this needed? I removed it and everything compiled fine it seems. > It is not needed, I have removed it. > > I am packaging Postgresql for version control since the pilotlog program is > > compiled against it. Is it a requirement that I use the Fedora postgresql > > package and libs? > > Unless there's a really good reason not to, yes. The fact that you're > trying to populate a database here is partially what I'm unsure about. I'm > not totally sure what the packaging policy is surrounding situations like > this since Postgres could be used for other things already running, etc. > Yes a database needs to be created and populated prior to compiling since the programs need the database schema to compile. > > %configure works but it does not compile when using %make_build > > It doesn't seem to like compiling with multiple threads. You can use > `%make_build -j1` to force it to 1 thread but ideally you can figure out why > it won't compile using multiple threads. I believe you're upstream/the > developer of this aren't you? Yes I am the developer. I put `%make_build -j1` in for now, but I will figure out why it doesn't work with multiple threads. > > How are you test building the RPM? You need to be using mock (or something > like `fedpkg --release rawhide mockbuild`). > rpmbuild --target x86_64 -ba pilotlog.spec > Why not also use `%make_install` instead of copying everything into place by > hand in the spec? I see the Makefile has some installation components in it > already. The Makefile copies into /usr/local/pilotlog and I want to use the same Makefile for Fedora packaging that I am using for anyone that downloads the source tarball and compiles. > > > Requires: ncurses%{?_isa} >= 6.2 > > This should instead be `BuildRequires: ncurses-devel`. RPM will then > automatically generate the proper `Requires` since it builds against it. [2] > I made this change. > I think a bunch of your psql related stuff is failing. I see a ton of this > in the build logs: > > 2022-08-11 18:29:25.788 CDT [570] ERROR: relation "syscolatt" does not > exist at character 81 > 2022-08-11 18:29:25.788 CDT [570] STATEMENT: DECLARE chkscatt_0 CURSOR > WITH HOLD FOR select syscolatt.def_format,seqno from syscolatt WHERE > tabname='log_entry' AND colname='entry_date' ORDER BY seqno > > --- > > On further looking at the source tarball I notice that Postgres you're > providing is already compiled which is definitely forbidden. [3] > I will make the change to use the Fedora postgresql. > --- > > 1. > https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ > #_buildrequires_and_requires > 2. > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > #_package_dependencies > 3. > https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be- > packaged/#prebuilt-binaries-or-libraries Spec URL: https://download.stansoft.org/files/pilotlog.spec SRPM URL: https://download.stansoft.org/files/pilotlog-9-2.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2117046 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
