https://bugzilla.redhat.com/show_bug.cgi?id=2117046 --- Comment #7 from Stansoft <rpm@xxxxxxxxxxxx> --- (In reply to Jonathan Wright from comment #6) > > # Omit /lib/.build-id to avoid conflict with included libs > > %global _build_id_links none > > # Filter internal libraries > > %global _privatelibs ^%{_libdir}/%{name}/.*\\.so$ > > %global __provides_exclude ^(%{_privatelibs})$ > > %global __requires_exclude ^(%{_privatelibs})$ > > %global __requires_exclude_from ^(%{_privatelibs})$ > > %global __filter_GLIBC_PRIVATE 1 > > Since I can't get the source code I'm not sure what all of this is for but > are you packaging libraries and trying to avoid using system libs? You > should almost always use system libs. [2][3] I am packaging Postgresql for version control since the pilotlog program is compiled against it. Is it a requirement that I use the Fedora postgresql package and libs? > > > Source0: %{name}-v%{version}-src.tar.bz2 > > This needs to be a URL. [1] > > > ./configure > > make > %configure works but it does not compile when using %make_build > You should use macros %configure and %make_build. [4] > > > cp installpl updatepl pl changelog COPYING README \ > > %{buildroot}%{_libdir}/%{name} > > > %pre > > %post > > %preun > > %postun > > These should be removed. > > > BuildRequires: systemd-rpm-macros > > Is this needed? > > You probably don't need changelog, COPYING, and README here. README and > changelog should fall under %doc and COPYING under %license. This takes > care of copying them into the correct places for you. [5] > > 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > 2. > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > AutoProvidesAndRequiresFiltering/#_summary > 3. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling > 4. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_parallel_make > 5. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation > > There are some other parts of this I'm not sure about at all and we'll have > to seek guidance from others. Here are the updated spec and source rpm Spec URL: https://download.stansoft.org/files/pilotlog.spec SRPM URL: https://download.stansoft.org/files/pilotlog-9-2.fc36.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2117046 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
