https://bugzilla.redhat.com/show_bug.cgi?id=2115901 --- Comment #12 from Richard Shaw <hobbes1069@xxxxxxxxx> --- I've got the review mostly completed but want to make sure we're both good on the licensing. This may be a pain but I think any of the bundled libraries should have their license file included: $ grep LICENSE licensecheck.txt ImHex/lib/libimhex-rs/imgui-rs/LICENSE-APACHE ImHex/lib/libimhex-rs/imgui-sys/LICENSE-APACHE ImHex/lib/external/nativefiledialog/LICENSE ImHex/lib/external/capstone/LICENSE.TXT ImHex/lib/external/capstone/bindings/python/LICENSE.TXT ImHex/lib/external/capstone/suite/regress/LICENSE ImHex/LICENSE ImHex/lib/external/pattern_language/LICENSE ImHex/resources/LICENSE.rtf ImHex/resources/romfs/LICENSE ImHex/lib/external/microtar/LICENSE ImHex/lib/external/pattern_language/external/fmt/LICENSE.rst ImHex/lib/external/pattern_language/external/intervaltree/LICENSE ImHex/lib/external/xdgpp/LICENSE ImHex/lib/libimhex-rs/imgui-rs/LICENSE-MIT ImHex/lib/libimhex-rs/imgui-sys/LICENSE-MIT ImHex/lib/external/capstone/LICENSE_LLVM.TXT In some cases they may be identical, so either include one? Or maybe just a little bash scripting in %install: cp ImHex/lib/libimhex-rs/imgui-rs/LICENSE-APACHE ./imgui-rs-LICENSE-APACHE etc... And then include in %license. Thoughts? -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2115901 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue