https://bugzilla.redhat.com/show_bug.cgi?id=2112474 --- Comment #24 from Kashyap Chamarthy <kchamart@xxxxxxxxxx> --- (In reply to John Snow from comment #23) > (In reply to Maxwell G from comment #20) [...] > > > rm %{buildroot}%{_bindir}/qmp-tui > > > > I'm not a fan of this. Fedora packages should try to stay close to upstream > > projects[1], and this feels like a deviation from that. I'm happy to help > > you split it out into a subpackage if needed. However, if you still maintain > > that this shouldn't be packaged, I won't push hard on it. > > > > [1]: > > https://docs.fedoraproject.org/en-US/package-maintainers/ > > Staying_Close_to_Upstream_Projects/ > > Understood. Currently, the TUI requires some packages that Fedora does not > yet package. I'm reluctant to split out another Python package for QEMU > before I'm fully finished with the first, so I think it's going to be a > while before it's in fighting shape to bother splitting, packaging, > documenting, etc. FWIW, I think it is fine to remove 'qmp-tui' as of now in this spec file. Yes, Fedora packages "should try to stay close to upstream projects", but within reason. Once the related dependencies are in place, it can be included in a later build. [...] -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2112474 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
