https://bugzilla.redhat.com/show_bug.cgi?id=2113075 --- Comment #10 from Jonathan Wright <jonathan@xxxxxxxxxxxxx> --- > a) Update last line of changelog 1.6.2-2 to 1.6.2-1 I'll build it using "-1" in the final build. I incremented here just to differentiate my changes. > b) It may be helpful to also add a copy of the FSFAP license in the > changelog to the licenses directory. The changelog is not currently installed anywhere. I'll package it and add FSFAP. > c) Not sure why getting license identifiers errors, they seem to match > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > LicensingGuidelines/ and https://spdx.org/licenses/ The license checker flags all the SPDX licenses right now. > d) Are the lines > mkdir -p %{buildroot}/%{_docdir}/%{name} > cp -a ChangeLog %{buildroot}/%{_docdir}/%{name}/ > install -p %{SOURCE1} -t %{buildroot}%{_datadir}/doc/%{name}/ > required? > What happens if you add > %doc README ChangeLog It will yield duplicate file listings in rpmlint. That's the only reason I swapped to this method. ie: RPM build warnings: File listed twice: /usr/share/doc/basez Do you happen to know if it's preferable to ignore these warnings and use %doc ? > e) Are the lines > # sent this patch to upstream. patch built for 1.6.2. > Patch0: add_disable_hex_opt.patch > still required? Yes. This patch is what makes the `--disable-hex-command` build flag work. > f) Seemed to build with most of these changes > https://copr.fedorainfracloud.org/coprs/fed500/basez/build/4717951/ > g) Probably with above can approve - > h) For my own knowledge, why use 2%{?dist} in the release field rather than > 1%{?dist} - > https://docs.fedoraproject.org/en-US/packaging-guidelines/DistTag/ See above. Just for incrementing changes here in the review. Will be -1 in release. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2113075 _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
